Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unable to create a new stream error on android system. #1506

Merged
merged 1 commit into from
May 3, 2023

Conversation

dongfengweixiao
Copy link
Contributor

PLEASE NOTE the following text from the iperf3 license. Submitting a
pull request to the iperf3 repository constitutes "[making]
Enhancements available...publicly":

You are under no obligation whatsoever to provide any bug fixes, patches, or
upgrades to the features, functionality or performance of the source code
("Enhancements") to anyone; however, if you choose to make your Enhancements
available either publicly, or directly to Lawrence Berkeley National
Laboratory, without imposing a separate written license agreement for such
Enhancements, then you hereby grant the following license: a non-exclusive,
royalty-free perpetual license to install, use, modify, prepare derivative
works, incorporate into other computer software, distribute, and sublicense
such enhancements or derivative works thereof, in binary and source code form.

The complete iperf3 license is available in the LICENSE file in the
top directory of the iperf3 source tree.

  • Version of iperf3 (or development branch, such as master or
    3.1-STABLE) to which this pull request applies:

master

  • Issues fixed (if any):

none

  • Brief description of code changes (suitable for use as a commit message):

when run iperf3 on android as server,

/data/local/tmp/iperf3 -s                                          
-----------------------------------------------------------
Server listening on 5201
-----------------------------------------------------------
Accepted connection from 192.168.0.2, port 61642
iperf3: error - unable to create a new stream: No such file or directory
-----------------------------------------------------------
Server listening on 5201
-----------------------------------------------------------

cause iperf3 use ‘/tmp’ as default tmp folder, but android only support ‘/data/local/tmp’.

@davidBar-On
Copy link
Contributor

@bmah888, I believe that this is a desired change for Android users and that there is no risk from the changes for non-Android users.

Note that there is a iperf3 repository for Android that was maintained up to iperf3 version 3.10.1 (I don't know more than that), and it seems that the only change to the source code was the change suggested by this PR - see this script.

@bmah888
Copy link
Contributor

bmah888 commented May 2, 2023

@bmah888, I believe that this is a desired change for Android users and that there is no risk from the changes for non-Android users.

Note that there is a iperf3 repository for Android that was maintained up to iperf3 version 3.10.1 (I don't know more than that), and it seems that the only change to the source code was the change suggested by this PR - see this script.

Tentatively I agree, this is probably low-risk change and helpful.

@bmah888 bmah888 assigned bmah888 and swlars and unassigned bmah888 May 3, 2023
Copy link
Contributor

@swlars swlars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!

@swlars swlars merged commit 2914636 into esnet:master May 3, 2023
@dongfengweixiao dongfengweixiao deleted the android_tmp_dir branch May 4, 2023 01:58
coolshou pushed a commit to coolshou/iperf that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants