Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
master
or3.1-STABLE
) to which this pull request applies: allIssues fixed (if any): -
Brief description of code changes (suitable for use as a commit message): Fix Segfault in iperf_err(exit)
In some places
iperf_err
andiperf_errexit
are called withNULL
for the parameterstruct iperf_test *test
. In this case thepthread_mutex_lock
call will Segfault. Fixed by adding a NULL-check.Reproduce this Segfault
Example of a usage of `iperf_errexit` with `NULL` (here)[https://github.com/esnet/iperf/blob/master/src/iperf_util.c#L68]. (Reproduce with a full `/tmp` filesystem, `readentropy` will fail)Valgrind output: