Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created MRML v3 for SENSE and added new BandwidthService #11

Merged
merged 3 commits into from
Sep 13, 2017

Conversation

jmacauley
Copy link
Collaborator

As part of the SENSE project we spawn a new schema version.

Added new BandwidthService to track port capacities and bandwidth utilized by a service.

Closes issue #10.

As part of the SENSE project we spawn a new schema version.

Added new BandwidthService to track port capacities and bandwidth utilized by a service.
@jmacauley jmacauley requested a review from xi-yang August 2, 2017 14:04
@xi-yang
Copy link
Collaborator

xi-yang commented Aug 2, 2017

  1. Typo: Several occurrences of BandwithService -> should be BandwidthService.

  2. capacity had already been defined with domain NetworkObject. It was redefined with domain BandwidthService.

@jmacauley
Copy link
Collaborator Author

BandwithService -> Good catch. Figures I copy the one with the incorrect spelling :-(

The existing capacity definition is:

<!-- http://schemas.ogf.org/mrs/2013/12/topology#capacity -->

<owl:DatatypeProperty rdf:about="http://schemas.ogf.org/mrs/2013/12/topology#capacity">
    <rdfs:domain rdf:resource="http://schemas.ogf.org/nml/2013/03/base#NetworkObject"/>
    <rdfs:range rdf:resource="http://www.w3.org/2001/XMLSchema#string"/>
</owl:DatatypeProperty>

Can I remove this one? It is defined as a string instead of a long and is bound to NetworkObject instead of the Bandwidth service. Are you using this definition in any other objects?

@xi-yang
Copy link
Collaborator

xi-yang commented Aug 2, 2017 via email

@jmacauley
Copy link
Collaborator Author

I am okay with changing "capacity" to "maximumCapacity", however, capacity was also used on the instantiated port to indicate how much capacity that port was using as part of the service. Should I create a "usedCapacity" to identify the capacity used by the service instance?

Fixed spelling mistake "BandwithService".

Changed "capacity" property to "maximumCapacity" to avoid conflict.
@xi-yang
Copy link
Collaborator

xi-yang commented Aug 2, 2017 via email

@jmacauley
Copy link
Collaborator Author

I know you like shorter names. Looking at the ones we have now it is possible to shorten them since they are in the context of the BandwidthService:

reservableCapacity == reservable
granularity == granularity
availableCapacity == available
maximumCapacity == maximum
usedCapacity == used
unit == unit

What do you think?

@xi-yang
Copy link
Collaborator

xi-yang commented Aug 2, 2017 via email

@xi-yang xi-yang merged commit 04c246e into master Sep 13, 2017
@xi-yang xi-yang deleted the create-nml-mrs-ext-v3 branch January 10, 2019 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants