reserved identifier violation

[elfring]

I would like to point out that identifiers like "__UMCONNECTION_H___" and "__PACKETREADER_H__" do not fit to the expected naming conventions of the C/C++ language standard.
Would you like to adjust your selection for unique names?

[jskorpan]

What part of the expected naming convention of the C/C++ language standard would that be in violation of?

[mthurlin]

ISO/IEC 14882-2003, Section 17.4.3.1.2 :)

[jskorpan]

Bastard : )

From: Markus Thurlin [mailto:notifications@github.com]
Sent: den 1 oktober 2012 22:14
To: esnme/ultramysql
Cc: Jonas Tärnström
Subject: Re: [ultramysql] reserved identifier violation (#19)

ISO/IEC 14882-2003, Section 17.4.3.1.2 :)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/19#issuecomment-9047896.

[elfring]

I recommend to delete double underscores from identifiers like include guards in the affected header files to make them a bit more standard-compliant.

[jskorpan]

Feel free to supply a pull request for this one, as of now since it's not an issue I'm not going to fix it.

Thanks!