This repository has been archived by the owner on Feb 22, 2020. It is now read-only.
Stop raising SystemError when no database name given #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asonable exception instead of SystemError on connection error
|
Thanks! |
jskorpan
pushed a commit
that referenced
this pull request
Apr 20, 2012
Stop raising SystemError when no database name given
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case
tests.testConnectAutoCommitOffalways fails, raisingSystemError: error return without exception set.After a bit of debugging, I found there is a little logic error when the database parameter is empty. I fixed the bug in this pull request, and use
HandleError()inConnection_connect()to raiseumysql.Errorexeceptions instead of meaninglessSystemError.