-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dict to ionic_steps typing #5
Add dict to ionic_steps typing #5
Conversation
@esoteric-ephemera I made a small oversight in my last PR, this should fix it. |
Hey Orion, I think I may have fixed this separately, can you double check that the ionic_steps are correctly stored as blobs? |
I just pulled the recent changes and I think this fix is still necessary. I am still getting an error when trying to reconstitute the doc as a pydantic object. Broadening the type to include dict fixed it for me. dict_doc = doc["output"]
task_doc = ForceFieldTaskDocument.parse_obj(dict_doc)
|
Very strange - I'm not getting these errors trying to reconstruct the doc (tried a few pydantic v2.7.x and 2.8.x) and ionic steps should be a list of dict when deserialized. Can you double check that |
Do you have an additional data store configured in your test environment? If not, we won't see the same behavior. I am getting >>> doc["output"]["output"]["ionic_steps"]
{'@class': '',
'@module': '',
'blob_uuid': '3e24b30f-97f3-40db-aeb7-266e0ca48118',
'store': 'data'} I checked and ForcefieldTaskDoc(**doc["output"]) hydrates correctly. |
Oh OK I see - specifying "output.ionic_steps" in the additional store data does not actually push ionic_steps to blob storage, but "ionic_steps" does |
By adding
"ionic_steps"
toDATA_OBJECTS
it changes the possible types. This is a small fix for that