Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update to better support case that the hardware isnt found #80

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

finger563
Copy link
Contributor

Description

  • Update espp to fix bug in touchscreen on ESP32-S3-BOX
  • Update menu / gui to better handle the case that the box-emu hardware (keypad) aren't found

Motivation and Context

  • Don't want the system to crash if the hardware isn't found.
  • Want it to work fully on BOX and BOX-3

How has this been tested?

Building and running without the gamepad hardware on both Box and Box-3

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Jul 15, 2024
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit f1f753c into main Jul 15, 2024
3 checks passed
@finger563 finger563 deleted the fix/hardware-error-checking branch July 15, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant