-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/bldc haptics #60
Merged
Merged
Commits on May 25, 2023
-
feat(bldc_haptics): initial bldc_haptics component
* Added bldc_haptics component which templates on a motor concept (works with bldc_motor right now) - copied with modifications from smartknob as initial implementation. * Added bldc_haptics_example to showcase new component.
Configuration menu - View commit details
-
Copy full SHA for 3522aef - Browse repository at this point
Copy the full SHA 3522aefView commit details -
Configuration menu - View commit details
-
Copy full SHA for 04aa8ab - Browse repository at this point
Copy the full SHA 04aa8abView commit details
Commits on May 26, 2023
-
* Updated PID config api to allow user to specify whether they want to clear the state or not (default true) * Added `set_config` api to mirror `get_config`
Configuration menu - View commit details
-
Copy full SHA for e6ee866 - Browse repository at this point
Copy the full SHA e6ee866View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c18925 - Browse repository at this point
Copy the full SHA 1c18925View commit details -
* Updated docs to include bldc haptics info * Updated bldc_haptics comments for more complete docs and remove unused code * Updated bldc_motor to point to example usage (was missing)
Configuration menu - View commit details
-
Copy full SHA for ae25fb9 - Browse repository at this point
Copy the full SHA ae25fb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for f66034f - Browse repository at this point
Copy the full SHA f66034fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f47e192 - Browse repository at this point
Copy the full SHA f47e192View commit details
Commits on May 27, 2023
-
* Added fault pin (optional) to bldc_driver as an input with associated API * Added mutex to protect en / fault pins (and check values before setting enable)
Configuration menu - View commit details
-
Copy full SHA for 208ddcf - Browse repository at this point
Copy the full SHA 208ddcfView commit details -
feat(bldc_motor): update example
* Update bldc_motor example to use config for tinyS3 test stand (works!) * Update bldc_motor example to quit if the driver reports a fault * Update bldc_driver to configure the fault pin as pull-down (since fault is high) to prevent always triggering fault condition
Configuration menu - View commit details
-
Copy full SHA for a76c066 - Browse repository at this point
Copy the full SHA a76c066View commit details -
Configuration menu - View commit details
-
Copy full SHA for cdd3bd9 - Browse repository at this point
Copy the full SHA cdd3bd9View commit details -
* Update bldc_haptics example to use fault pin on motor driver and exit if the driver goes into fault condition
Configuration menu - View commit details
-
Copy full SHA for 550a203 - Browse repository at this point
Copy the full SHA 550a203View commit details
Commits on May 29, 2023
-
feat(bldc_haptics): allow pid config
* Allow the kp/kd factors to be configured in the BldcHaptics::Config struct * Fix potential bug from smartknob project where min/max (lower/upper) kd factors were inverted
Configuration menu - View commit details
-
Copy full SHA for dde3d42 - Browse repository at this point
Copy the full SHA dde3d42View commit details
Commits on May 31, 2023
-
feat(bldc_motor): refactor types
* Moved non-templated types into their own header files (now inside espp::detail namespace) and updated example accordingly
Configuration menu - View commit details
-
Copy full SHA for abfe080 - Browse repository at this point
Copy the full SHA abfe080View commit details -
feat(bldc_haptics): updated interface
* Allow configuring the pid gain factors for detents of BldcHaptics * Update to use new espp::detail namespace for types in BldcMotor * Set motor to Torque control in BldcHaptics * Add motion control config api to concept requirement in BldcHaptics * Tuning the gain factors for the detent pid * Added another detent config (on/off) * Updated return to center detent config to have position width properly set
Configuration menu - View commit details
-
Copy full SHA for 59e8acf - Browse repository at this point
Copy the full SHA 59e8acfView commit details -
* Added missing parameter documentation to rtsp method
Configuration menu - View commit details
-
Copy full SHA for 4ec09be - Browse repository at this point
Copy the full SHA 4ec09beView commit details -
* Added missing parameter documentation * Send multiline response as multiline response (multiline=true) for FEAT
Configuration menu - View commit details
-
Copy full SHA for a56542a - Browse repository at this point
Copy the full SHA a56542aView commit details
Commits on Jun 1, 2023
-
feat(bldc_haptics): updated haptics
* Updated example to better indicate what config it is running (print it out completely) * Updated detent config to support libfmt printing * Added equality operator for detentconfig * Removed integrator for detent pid and increased output min/max * Updated gains for feeling of detents
Configuration menu - View commit details
-
Copy full SHA for 65f3ff7 - Browse repository at this point
Copy the full SHA 65f3ff7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5f41ca - Browse repository at this point
Copy the full SHA d5f41caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 671d80f - Browse repository at this point
Copy the full SHA 671d80fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 682ca04 - Browse repository at this point
Copy the full SHA 682ca04View commit details
Commits on Jun 2, 2023
-
* Remove integrator from detent PID * Add example for playing haptics to doc * Add API for getting current position from the haptics (for input)
Configuration menu - View commit details
-
Copy full SHA for e162a78 - Browse repository at this point
Copy the full SHA e162a78View commit details -
* Update pid config for haptics * Shorten example * Run the haptic click / buzz test and add it to docs
Configuration menu - View commit details
-
Copy full SHA for b52a513 - Browse repository at this point
Copy the full SHA b52a513View commit details -
Configuration menu - View commit details
-
Copy full SHA for 114392e - Browse repository at this point
Copy the full SHA 114392eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e1d2c3 - Browse repository at this point
Copy the full SHA 1e1d2c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a874795 - Browse repository at this point
Copy the full SHA a874795View commit details -
feat(bldc_haptics): better behavior
* Run the loop_foc after calling the move command, instead of after the sleep like a dumbass. * Update logger to print higher precision
Configuration menu - View commit details
-
Copy full SHA for 58c45bb - Browse repository at this point
Copy the full SHA 58c45bbView commit details
Commits on Jun 3, 2023
-
feat(bldc_motor): minor update
* Add phase inductance parameter to bldc_motor (not tested) * Update bldc_motor example to use motor for printing sensor data * Update bldc_motor example to have proper zero electrical angle for motor on new test stand. * Update bldc_motor example for less clamping
Configuration menu - View commit details
-
Copy full SHA for ffaaad5 - Browse repository at this point
Copy the full SHA ffaaad5View commit details -
feat(bldc_haptics): working haptics example
* updated haptics example to have correct zero electrical offset for this motor on this test stand * updated haptics example to have higher current limit * Updated to show more of the possible preconfigured detent configs and print them more cleanly * Updated bldc_haptics output min/max to be same as velocity pid was since they both operate on current * Updated logging for bldc_haptics * Updated how position is updated when changing detent configuration * Updated use of kd_factor_min/max to match how smartknob did it * Properly send the torque to the motor (not the negative torque) * Updated libfmt printing of DetentConfig structs
Configuration menu - View commit details
-
Copy full SHA for b71ab12 - Browse repository at this point
Copy the full SHA b71ab12View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fb55f1 - Browse repository at this point
Copy the full SHA 8fb55f1View commit details -
feat(bldc_haptics): update example
* Update gains in example * Update default gains
Configuration menu - View commit details
-
Copy full SHA for 886d5e3 - Browse repository at this point
Copy the full SHA 886d5e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3beb88 - Browse repository at this point
Copy the full SHA e3beb88View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.