-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add esp32 and esp32c3 VSCode debugging section #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, thanks for writing all these out! I've requested a handful of small changes be made if you don't mind, after that I'm happy to merge.
Thanks @jessebraham ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We might have to change the title of the section if we ever have a probe-rs vscode configuration, but we'll cross that bridge when we get to it :D. Great work @JurajSadel!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes @JurajSadel, and thanks for the additional review @MabezDev!
closes #29