Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add esp32 and esp32c3 VSCode debugging section #30

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

JurajSadel
Copy link
Contributor

closes #29

@JurajSadel JurajSadel requested a review from jessebraham June 21, 2022 19:07
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks for writing all these out! I've requested a handful of small changes be made if you don't mind, after that I'm happy to merge.

@JurajSadel
Copy link
Contributor Author

Thanks @jessebraham !

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We might have to change the title of the section if we ever have a probe-rs vscode configuration, but we'll cross that bridge when we get to it :D. Great work @JurajSadel!

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes @JurajSadel, and thanks for the additional review @MabezDev!

@jessebraham jessebraham merged commit 295c77e into esp-rs:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to debug with vscode
3 participants