Overhaul ecosystem overview #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restructure the chapter Setting Up the Development Environment
Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
|
@SergioGasquez PTAL |
SergioGasquez
requested changes
Mar 29, 2023
6 tasks
Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
|
There are only unresolved comments about the Otherwise, I don't have any other suggestions or ideas to add. |
Just created https://github.com/f-hollow/Rust-on-ESP/pull/2 with my suggestions, feel free to coment! |
There was a problem hiding this comment.
Just read the whole chapter again and left some minor suggestions, most of them are formatting, but there are 2 interesting additions from @JurajSadel blogpost
Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
|
I resolved all comments. Once the work on the Style Guide MR is finished, we might need to still apply a few fixes for this chapter to conform. Otherwise, I have nothing to add. Feel free to merge it. @jessebraham @bjoernQ Thank you for your review comments as well! |
SergioGasquez
added a commit
to SergioGasquez/book
that referenced
this pull request
Apr 27, 2023
* Update index.md Restructure the chapter Setting Up the Development Environment * Update according to comments from Sergio * Update src/installation/index.md * Update src/installation/index.md * Update src/installation/index.md * Update index.md * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update index.md * Update RISC-V and Xtensa targets section names * Update link variable names * Update index.md * Update comparing-std-and-no_std * Update using-the-standard-library * Update bare-metal * Update table alignment * Update alignment * Restore installation/intex.md to its pre-fork state * Fix title syntax * Update src/overview/bare-metal.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/bare-metal.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/bare-metal.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/bare-metal.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/using-the-standard-library.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/comparing-std-and-no_std.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Implement comments for Sergio * Add a link to ESP8266 HAL * Add the newlib link * Update src/overview/using-the-standard-library.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Add link to esp-idf-release-compatibility table * Add link to esp-idf-release-compatibility table * Update sentence with link to esp-idf compatibility * Delete duplicate link definition * Add intro paragraph to std vs no_std * Remove the intro to esp-idf-svc * Remove Section Software Stacks * Add the table legend * Fix link issue * Update src/overview/comparing-std-and-no_std.md * Move FAQ to Troubleshooting * Add FAQ content * Update table covering no_std crates * Update link to ESP8266 HAL * Update src/overview/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * fix: ⚡️ Update no_std support table * refactor: ♻️ Move comparison to index * fix: 🐛 Fix link * Improve the formatting of a list * Remove the symbol column * feat: 🎨 Update support tables * FIx markdown note formatting issue Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix formatting for a ref to another section Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Add monospace font to terms Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Include section on bare metal from Jurajs blogpost Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Include section on standard library from Jurajs blogpost Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix typos * Update ESP32-H2 curent support --------- Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
jessebraham
pushed a commit
that referenced
this pull request
May 2, 2023
* Update index.md Restructure the chapter Setting Up the Development Environment * Update according to comments from Sergio * Update src/installation/index.md * Update src/installation/index.md * Update src/installation/index.md * Update index.md * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update index.md * Update RISC-V and Xtensa targets section names * Update link variable names * Update index.md * Update comparing-std-and-no_std * Update using-the-standard-library * Update bare-metal * Update table alignment * Update alignment * Restore installation/intex.md to its pre-fork state * Fix title syntax * Update src/overview/bare-metal.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/bare-metal.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/bare-metal.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/bare-metal.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/using-the-standard-library.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/comparing-std-and-no_std.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Implement comments for Sergio * Add a link to ESP8266 HAL * Add the newlib link * Update src/overview/using-the-standard-library.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Add link to esp-idf-release-compatibility table * Add link to esp-idf-release-compatibility table * Update sentence with link to esp-idf compatibility * Delete duplicate link definition * Add intro paragraph to std vs no_std * Remove the intro to esp-idf-svc * Remove Section Software Stacks * Add the table legend * Fix link issue * Update src/overview/comparing-std-and-no_std.md * Move FAQ to Troubleshooting * Add FAQ content * Update table covering no_std crates * Update link to ESP8266 HAL * Update src/overview/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * fix: ⚡️ Update no_std support table * refactor: ♻️ Move comparison to index * fix: 🐛 Fix link * Improve the formatting of a list * Remove the symbol column * feat: 🎨 Update support tables * FIx markdown note formatting issue Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix formatting for a ref to another section Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Add monospace font to terms Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Include section on bare metal from Jurajs blogpost Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Include section on standard library from Jurajs blogpost Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix typos * Update ESP32-H2 curent support --------- Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
SergioGasquez
added a commit
to SergioGasquez/book
that referenced
this pull request
May 30, 2023
* Update index.md Restructure the chapter Setting Up the Development Environment * Update according to comments from Sergio * Update src/installation/index.md * Update src/installation/index.md * Update src/installation/index.md * Update index.md * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update index.md * Update RISC-V and Xtensa targets section names * Update link variable names * Update index.md * Update comparing-std-and-no_std * Update using-the-standard-library * Update bare-metal * Update table alignment * Update alignment * Restore installation/intex.md to its pre-fork state * Fix title syntax * Update src/overview/bare-metal.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/bare-metal.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/bare-metal.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/bare-metal.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/using-the-standard-library.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/comparing-std-and-no_std.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Implement comments for Sergio * Add a link to ESP8266 HAL * Add the newlib link * Update src/overview/using-the-standard-library.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Add link to esp-idf-release-compatibility table * Add link to esp-idf-release-compatibility table * Update sentence with link to esp-idf compatibility * Delete duplicate link definition * Add intro paragraph to std vs no_std * Remove the intro to esp-idf-svc * Remove Section Software Stacks * Add the table legend * Fix link issue * Update src/overview/comparing-std-and-no_std.md * Move FAQ to Troubleshooting * Add FAQ content * Update table covering no_std crates * Update link to ESP8266 HAL * Update src/overview/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * fix: ⚡️ Update no_std support table * refactor: ♻️ Move comparison to index * fix: 🐛 Fix link * Improve the formatting of a list * Remove the symbol column * feat: 🎨 Update support tables * FIx markdown note formatting issue Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix formatting for a ref to another section Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Add monospace font to terms Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Include section on bare metal from Jurajs blogpost Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Include section on standard library from Jurajs blogpost Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix typos * Update ESP32-H2 curent support --------- Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
SergioGasquez
added a commit
to SergioGasquez/book
that referenced
this pull request
May 30, 2023
* Update index.md Restructure the chapter Setting Up the Development Environment * Update according to comments from Sergio * Update src/installation/index.md * Update src/installation/index.md * Update src/installation/index.md * Update index.md * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/installation/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Apply suggestions from code review Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update index.md * Update RISC-V and Xtensa targets section names * Update link variable names * Update index.md * Update comparing-std-and-no_std * Update using-the-standard-library * Update bare-metal * Update table alignment * Update alignment * Restore installation/intex.md to its pre-fork state * Fix title syntax * Update src/overview/bare-metal.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/bare-metal.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/bare-metal.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/bare-metal.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/using-the-standard-library.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Update src/overview/comparing-std-and-no_std.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Implement comments for Sergio * Add a link to ESP8266 HAL * Add the newlib link * Update src/overview/using-the-standard-library.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Add link to esp-idf-release-compatibility table * Add link to esp-idf-release-compatibility table * Update sentence with link to esp-idf compatibility * Delete duplicate link definition * Add intro paragraph to std vs no_std * Remove the intro to esp-idf-svc * Remove Section Software Stacks * Add the table legend * Fix link issue * Update src/overview/comparing-std-and-no_std.md * Move FAQ to Troubleshooting * Add FAQ content * Update table covering no_std crates * Update link to ESP8266 HAL * Update src/overview/index.md Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * fix: ⚡️ Update no_std support table * refactor: ♻️ Move comparison to index * fix: 🐛 Fix link * Improve the formatting of a list * Remove the symbol column * feat: 🎨 Update support tables * FIx markdown note formatting issue Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix formatting for a ref to another section Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Add monospace font to terms Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Include section on bare metal from Jurajs blogpost Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Include section on standard library from Jurajs blogpost Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix a typo Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> * Fix typos * Update ESP32-H2 curent support --------- Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.