Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Add feature to exit with semihosting::process:abort() #40

Closed
wants to merge 1 commit into from

Conversation

t-moe
Copy link

@t-moe t-moe commented Nov 21, 2023

Useful to get defmt_test working on esp32 riscv. ( knurling-rs/defmt#796)

build.rs Show resolved Hide resolved
@bjoernQ
Copy link
Contributor

bjoernQ commented Nov 27, 2023

Just a thought: could we avoid the additional dependency? It's just a glorified ebreak and we really just want one syscall 🤔

https://github.com/riscv-software-src/riscv-semihosting/blob/HEAD/riscv-semihosting-spec.adoc

However, that dependency isn't a show-stopper here - but I think it would be easy to avoid it. I can also imagine adding it now and replacing it later

@t-moe
Copy link
Author

t-moe commented Nov 27, 2023

Just a thought: could we avoid the additional dependency? It's just a glorified ebreak and we really just want one syscall 🤔

I actually set the PR status back to draft, because I can also get defmt_test working without modifications on esp-backtrace and esp-println by using defmt-rtt and panic-probe. I'm still evaluating which road to pursue....

@bjoernQ
Copy link
Contributor

bjoernQ commented Nov 27, 2023

I think when using RTT the better option is to use defmt-rtt / panic-probe 👍

@jessebraham
Copy link
Member

I think when using RTT the better option is to use defmt-rtt / panic-probe 👍

I agree, however unfortunately panic-probe is currently ARM-specific, and needs updating to support our chips.

@t-moe
Copy link
Author

t-moe commented Nov 27, 2023

unfortunately panic-probe is currently ARM-specific, and needs updating to support our chips.

True.

I'm working on that in knurling-rs/defmt#796 , but waiting on feedback for now.

@bjoernQ
Copy link
Contributor

bjoernQ commented Jan 30, 2024

We probably can close this? Feel free to re-open as needed

@bjoernQ bjoernQ closed this Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants