style: Clippy lints

xtask/src/lib.rs

@@ -462,8 +462,8 @@ pub fn generate_efuse_table(
     // Determine the commit (short) hash of the HEAD commit in the
     // provided ESP-IDF repository:
     let output = Command::new("git")
-        .args(&["rev-parse", "HEAD"])
-        .current_dir(&idf_path)
+        .args(["rev-parse", "HEAD"])
+        .current_dir(idf_path)
         .output()?;
     let idf_hash = String::from_utf8_lossy(&output.stdout[0..=7]).to_string();
 

xtask/src/main.rs

@@ -142,7 +142,7 @@ fn build_documentation(workspace: &Path, args: BuildDocumentationArgs) -> Result
     let resources = workspace.join("resources");
 
     let package = args.package.to_string();
-    let version = xtask::package_version(&workspace, args.package)?;
+    let version = xtask::package_version(workspace, args.package)?;
 
     let mut crates = Vec::new();
 
@@ -188,10 +188,7 @@ fn build_documentation(workspace: &Path, args: BuildDocumentationArgs) -> Result
     }
 
     // Copy any additional assets to the documentation's output path:
-    fs::copy(
-        &resources.join("esp-rs.svg"),
-        &output_path.join("esp-rs.svg"),
-    )?;
+    fs::copy(resources.join("esp-rs.svg"), output_path.join("esp-rs.svg"))?;
 
     // Render the index and write it out to the documentaiton's output path:
     let source = fs::read_to_string(resources.join("index.html.jinja"))?;
@@ -280,7 +277,7 @@ fn generate_efuse_src(workspace: &Path, args: GenerateEfuseFieldsArgs) -> Result
 
     // Generate the Rust source file from the CSV file, and write it out to
     // the appropriate path:
-    xtask::generate_efuse_table(&args.chip, &idf_path, out_path)?;
+    xtask::generate_efuse_table(&args.chip, idf_path, out_path)?;
 
     // Format the generated code:
     xtask::cargo::run(&["fmt".into()], &esp_hal)?;
@@ -337,7 +334,7 @@ fn run_example(workspace: &Path, mut args: RunExampleArgs) -> Result<()> {
     Ok(())
 }
 
-fn run_tests(workspace: &PathBuf, args: RunTestsArgs) -> Result<(), anyhow::Error> {
+fn run_tests(workspace: &Path, args: RunTestsArgs) -> Result<(), anyhow::Error> {
     // Absolute path of the package's root:
     let package_path = xtask::windows_safe_path(&workspace.join("hil-test"));