Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty printing panic messages on nightly broken #1818

Closed
bjoernQ opened this issue Jul 17, 2024 · 0 comments · Fixed by #1823
Closed

Pretty printing panic messages on nightly broken #1818

bjoernQ opened this issue Jul 17, 2024 · 0 comments · Fixed by #1823
Assignees
Labels
package:esp-backtrace Issues related to the esp-backtrace package
Milestone

Comments

@bjoernQ
Copy link
Contributor

bjoernQ commented Jul 17, 2024

Before we were able to pretty print panic messages on nightly.

See esp-rs/esp-backtrace#50

If we don't want that anymore we should remove the conditionals from

#[cfg(not(any(nightly_before_2024_06_12, nightly_since_2024_06_12)))]
{
#[cfg(not(feature = "defmt"))]
println!("{:#?}", info);
#[cfg(feature = "defmt")]
println!("{:#?}", defmt::Display2Format(info));
}
#[cfg(nightly_before_2024_06_12)]
{
if let Some(message) = info.message() {
#[cfg(not(feature = "defmt"))]
println!("{}", message);
#[cfg(feature = "defmt")]
println!("{}", defmt::Display2Format(message));
}
}
#[cfg(nightly_since_2024_06_12)]
{
let message = info.message();
#[cfg(not(feature = "defmt"))]
println!("{}", message);
#[cfg(feature = "defmt")]
println!("{}", defmt::Display2Format(&message));
}
or we should re-enable the functionality

@bjoernQ bjoernQ added the package:esp-backtrace Issues related to the esp-backtrace package label Jul 17, 2024
@MabezDev MabezDev added this to the 0.20.0 milestone Jul 17, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:esp-backtrace Issues related to the esp-backtrace package
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants