Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier panic message printing #1823

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Jul 17, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

This improves the panic-message printing to look like this (no matter if stable or nightly)

image

Fixes #1818

Testing

Change one of the examples to explicitly panic and see the result

@bjoernQ bjoernQ marked this pull request as ready for review July 17, 2024 15:41
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MabezDev MabezDev added this pull request to the merge queue Jul 18, 2024
Merged via the queue into esp-rs:main with commit 917756a Jul 18, 2024
31 checks passed
@bjoernQ bjoernQ deleted the cleanup-panic-message-handling branch November 26, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pretty printing panic messages on nightly broken
3 participants