Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check missing embassy_XX examples to the CI #1048

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Check missing embassy_XX examples to the CI #1048

merged 2 commits into from
Dec 20, 2023

Conversation

JurajSadel
Copy link
Contributor

@JurajSadel JurajSadel commented Dec 20, 2023 •
edited
Loading

Thank you!

Thank you for your contribution.
Please make sure that your submission includes the following:

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

@JurajSadel JurajSadel added the skip-changelog No changelog modification needed label Dec 20, 2023
jessebraham
jessebraham approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I still think we need to re-visit our CI jobs for these packages, but for the time being this puts us in much better shape than we were in, at least 😁

@JurajSadel
Copy link
Contributor Author

While working on this PR I was thinking about going from cargo check to cargo build - but it requires more changes - does it make sense to invest time into this change or not? :D

@jessebraham
Copy link
Member

We should be using cargo build, sorry I missed that. If you want to change it in this PR feel free, if not don't worry about it (as I said, we will be updating the CI workflow again anyway)

@JurajSadel
Copy link
Contributor Author

I can look into that but I would prefer to do it in a separate PR.

SergioGasquez
SergioGasquez approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Edit: a bit late to the party, are we still evaluating doing the #900 approach?

@jessebraham jessebraham added this pull request to the merge queue Dec 20, 2023
Merged via the queue into esp-rs:main with commit 07b2b0d Dec 20, 2023
18 checks passed
@JurajSadel JurajSadel deleted the ci-examples branch December 20, 2023 17:01
Volkalex28 pushed a commit to Volkalex28/esp-hal that referenced this pull request Feb 6, 2024
@JurajSadel @Volkalex28
Check missing embassy_XX examples to the CI (esp-rs#1048)
92819af 
* CI: add missing examples

* H2: remove embassy-time-systick feature from embassy_i2c example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

@SergioGasquez SergioGasquez SergioGasquez approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JurajSadel @jessebraham @SergioGasquez