Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove (unused) heapless dependency #1148

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Remove (unused) heapless dependency #1148

merged 1 commit into from
Feb 8, 2024

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Feb 8, 2024

For some reason we have a dependency on heapless we don't use it and we shouldn't use it

@bjoernQ bjoernQ added the skip-changelog No changelog modification needed label Feb 8, 2024
JurajSadel
JurajSadel approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjoernQ bjoernQ added this pull request to the merge queue Feb 8, 2024
Merged via the queue into esp-rs:main with commit 66090ac Feb 8, 2024
18 checks passed
@bjoernQ bjoernQ deleted the remove-unused-dependency branch February 8, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JurajSadel JurajSadel JurajSadel approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernQ @JurajSadel