Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the xtask package, implement automation for building examples #1157

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

jessebraham
Copy link
Member

This is just the first rendition of this automation package, I plan to add more functionality soon, but this at least serves as a starting point.

This may look a little strange at first glance as I've developed it in parallel to my HAL unification efforts, however it's completely standalone so figured I'd PR it separately just to help keep things as reviewable as possible. I can confirm that it is working with my development branch.

This allows us to specify which chips are supported by various examples, and which features these examples may need to build. For example:

//% CHIPS: esp32 esp32s2 esp32s3
//% FEATURES: foo bar baz

This is not being checked by CI; it will need to be used in order to even run our CI soon, so it does not need an explicit check IMO.

@jessebraham jessebraham added the skip-changelog No changelog modification needed label Feb 12, 2024
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like this direction a lot, I think it will make our lives a whole lot easier in the long run.

Thanks!

@jessebraham jessebraham added this pull request to the merge queue Feb 12, 2024
Merged via the queue into esp-rs:main with commit ebdd59b Feb 12, 2024
18 checks passed
@jessebraham jessebraham deleted the feature/xtask branch February 12, 2024 15:42
@bjoernQ
Copy link
Contributor

bjoernQ commented Feb 12, 2024

Oh I'm a bit late to the party but I like this a lot!

@jessebraham jessebraham mentioned this pull request Feb 15, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants