Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of README.md for the examples package #1237

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

jessebraham
Copy link
Member

This is pretty basic, but just wanted to get a start so people can make suggestions. Not sure what else, if anything, needs mentioning, but maybe we can go into more detail about other parts here. Anyway, lemme know.

@jessebraham jessebraham added the skip-changelog No changelog modification needed label Mar 4, 2024
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really good to me, thanks!

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for documenting this!

@bjoernQ bjoernQ mentioned this pull request Mar 4, 2024
8 tasks
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! After reading this, I feel little bit depressed going back to my docs PR, haha 😅

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jessebraham jessebraham added this pull request to the merge queue Mar 4, 2024
Merged via the queue into esp-rs:main with commit e1c8206 Mar 4, 2024
1 check passed
@jessebraham jessebraham deleted the feature/readme branch March 4, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants