Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMT: allow driver to init as blocking or async #1341

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Mar 22, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • My changes were added to the CHANGELOG.md in the proper section.

Extra:

Pull Request Details 📖

Description

Makes it possible to create RMT in blocking or async mode.

Testing

The examples still work

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Mar 22, 2024

Closes #1322

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tested examples on esp32, c3, c6, and s2 and they're working fine for me!
Thanks!

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for this!

@jessebraham jessebraham added this pull request to the merge queue Mar 25, 2024
Merged via the queue into esp-rs:main with commit fd4f559 Mar 25, 2024
20 checks passed
yanshay pushed a commit to yanshay/esp-hal that referenced this pull request Mar 25, 2024
* RMT: allow driver to init as blocking or async

* CHANGELOG and minor fixes
@bjoernQ bjoernQ deleted the runtime-async-rmt branch November 26, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants