Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update probe-rs version #1374

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Apr 2, 2024

Description

Updates the probe-rs version used on the self-hosted-runners.

Testing

Manually triggered a HIL workflow after doing the update in the VMs: https://github.com/esp-rs/esp-hal/actions/runs/8519073237/job/23332371367

@SergioGasquez SergioGasquez added the skip-changelog No changelog modification needed label Apr 2, 2024
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the CI is bugged?

@SergioGasquez
Copy link
Member Author

LGTM, but the CI is bugged?

Looks like since the only change its in the README, the workflow is not triggered (https://github.com/esp-rs/esp-hal/blob/main/.github/workflows/ci.yml#L20)

@MabezDev
Copy link
Member

MabezDev commented Apr 2, 2024

LGTM, but the CI is bugged?

Looks like since the only change its in the README, the workflow is not triggered (https://github.com/esp-rs/esp-hal/blob/main/.github/workflows/ci.yml#L20)

😭. I guess we can bypass protections in this case, as we're not modifying code?

@MabezDev MabezDev merged commit c8bd107 into esp-rs:main Apr 2, 2024
2 checks passed
@SergioGasquez SergioGasquez deleted the feat/probe-rs branch April 2, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants