Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide native APIs for I2C/SPI functionality currently handled by embedded-hal@0.2.x traits #1386

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

jessebraham
Copy link
Member

I was a little unsure of a few things with regard to our SPI driver, so @bjoernQ please let me know if anything doesn't look right here. I think this should be correct, though 😅

@jessebraham jessebraham added the skip-changelog No changelog modification needed label Apr 3, 2024
@jessebraham jessebraham changed the title Provide native APIs for SPI functionality currently handled by embedded-hal@0.2.x traits Provide native APIs for I2C/SPI functionality currently handled by embedded-hal@0.2.x traits Apr 3, 2024
@jessebraham
Copy link
Member Author

I2C was easy, so added that here as well, because why not 😁

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me but haven't tested because I'm AFK right now

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jessebraham jessebraham added this pull request to the merge queue Apr 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 4, 2024
@jessebraham jessebraham added this pull request to the merge queue Apr 4, 2024
Merged via the queue into esp-rs:main with commit bf2cca9 Apr 4, 2024
21 checks passed
@jessebraham jessebraham deleted the fixes/embedded-hal branch April 4, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants