-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Software interrupts runtime binding #1398
Software interrupts runtime binding #1398
Conversation
6591237
to
aabbeb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, thank you for working on this! I left a few comments regarding missing docs for public structs and functions.
dac87e0
to
7e36f49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice improvement all round, thanks for taking care of this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for adding docs!
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
Split SoftwareInterruptControl, make it possible to register interrupt handlers, make interrupt-executor require a SoftwareInterrupt
When the thread-executor feature is enabled we remove
software_interrupt0
now - that's because it's used by the executor and there is no way to require it to get passed in (since the executor is created before main)There is currently an open TODO for P4 but given we don't even compile a single example for it yet and it's not a priority right now that should be fine IMHO
Testing
Run the adapted examples