Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Software interrupts runtime binding #1398

Merged
merged 9 commits into from
Apr 5, 2024

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Apr 4, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • My changes were added to the CHANGELOG.md in the proper section.

Extra:

Pull Request Details 📖

Description

Split SoftwareInterruptControl, make it possible to register interrupt handlers, make interrupt-executor require a SoftwareInterrupt

When the thread-executor feature is enabled we remove software_interrupt0 now - that's because it's used by the executor and there is no way to require it to get passed in (since the executor is created before main)

There is currently an open TODO for P4 but given we don't even compile a single example for it yet and it's not a priority right now that should be fine IMHO

Testing

Run the adapted examples

@bjoernQ bjoernQ force-pushed the software-interrupts-runtime-binding branch from 6591237 to aabbeb6 Compare April 4, 2024 15:36
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thank you for working on this! I left a few comments regarding missing docs for public structs and functions.

@bjoernQ bjoernQ force-pushed the software-interrupts-runtime-binding branch from dac87e0 to 7e36f49 Compare April 5, 2024 11:23
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice improvement all round, thanks for taking care of this!

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding docs!

@MabezDev MabezDev added this pull request to the merge queue Apr 5, 2024
Merged via the queue into esp-rs:main with commit b3bc28e Apr 5, 2024
21 checks passed
@bjoernQ bjoernQ deleted the software-interrupts-runtime-binding branch November 26, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants