Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RMT TX larger than one block work on ESP32-C3 and ESP32-S3 #143

Merged

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Aug 9, 2022

For ESP32-C3 and ESP32-S3 it wasn't possible to use RMT/PulseControl to transmit anything that is larger than one RMT memory block. This is a fix for that and also adds examples of using the raw PulseControl w/o the SmartLED feature.

This fixes #120

Please note: because of the way how this works you have to compile in release mode if the whole transaction doesn't fit into one memory block

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@jessebraham jessebraham merged commit 91373ac into esp-rs:main Aug 9, 2022
@bjoernQ bjoernQ deleted the bugfix/fix-rmt-for-esp32c3-esp32s3 branch December 14, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SmartLedAdapter.write() hangs when using more than one LED
2 participants