Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional HIL tests for UART #1511

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

jessebraham
Copy link
Member

We were not really testing much for this peripheral, so I've added a couple more test cases to at least exercise a bit more of our API. Verified locally on ESP32-C6.

@jessebraham jessebraham added the skip-changelog No changelog modification needed label Apr 25, 2024
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

I've locally tested H2 and S3 too and they were working fine

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JurajSadel JurajSadel added this pull request to the merge queue Apr 26, 2024
Merged via the queue into esp-rs:main with commit 0354880 Apr 26, 2024
21 checks passed
@jessebraham jessebraham deleted the feature/hil-test branch April 26, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants