Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable gpio::test_gpio_interrupt for Xtensa targets. #1555

Merged
merged 2 commits into from
May 15, 2024
Merged

Enable gpio::test_gpio_interrupt for Xtensa targets. #1555

merged 2 commits into from
May 15, 2024

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented May 15, 2024 •
edited
Loading

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.

Extra:

Pull Request Details 📖

Description

Enable gpio::test_gpio_interrupt for Xtensa targets, it was disabled due to #1413. I've also updated the runners probe-rs to rev a6dd038 which includes the fix.

Testing

Manually triggered the HIL CI workflow: https://github.com/esp-rs/esp-hal/actions/runs/9092616672
On S3:

test tests::test_gpio_interrupt ... ok

@SergioGasquez SergioGasquez added the skip-changelog No changelog modification needed label May 15, 2024
@SergioGasquez SergioGasquez linked an issue May 15, 2024 that may be closed by this pull request
GPIO test test_gpio_interrupt is failing for Xtensa targets #1413
Closed
JurajSadel
JurajSadel approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@SergioGasquez SergioGasquez marked this pull request as ready for review May 15, 2024 08:50
MabezDev
MabezDev approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@MabezDev MabezDev enabled auto-merge May 15, 2024 09:01
@MabezDev MabezDev added this pull request to the merge queue May 15, 2024
Merged via the queue into esp-rs:main with commit 3c05759 May 15, 2024
22 checks passed
@SergioGasquez SergioGasquez deleted the feat/update-probers branch May 15, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JurajSadel JurajSadel JurajSadel approved these changes

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GPIO test test_gpio_interrupt is failing for Xtensa targets
3 participants
@SergioGasquez @MabezDev @JurajSadel