[1/3] DMA Move API: Pull out driver specific state in DMA driver into… #1716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… separate structs
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
This part of #1512.
This is a no-op refactor of the DMA driver to move (what will eventually become) driver specific state to separate structs.
The new structs are:
DescriptorChain
- Each DMA capable driver will own either one or two chains. One for RX and one for TX.TxCircularState
/RxCircularState
- This will be owned by theDmaTransfer(Tx|Rx)Circular
(and the custom I2S transfer) structs.These new structs are currently
pub
due to other structs using them beingpub
too. After the 2nd PR, they becomepub(crate)
.I've split up this work into 3 PRs.
The reason I've split up this work into multiple PRs is to make this easier to review and to make my life much easier when I (inevitably) have to rebase on top of other breaking changes.
Since this PR is an internal refactor, I've omitted the CHANGELOG entry.
Testing
HIL in CI