Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin version of paste to fix build errors #176

Merged

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Aug 31, 2022

A few hours ago, the paste crate got a seemingly semver compatible update: https://crates.io/crates/paste/1.0.9

For us this causes a lot of trouble and failing builds. For now, this pins the paste crate to version 1.0.8

I don't see an easy way to fix things for 1.0.9 - let's see if there will be a 1.0.10 fixing that or if we need to come up with something.

For now, this should fix things

However, I guess that the already published HALs will be broken now - needs to be verified

@JurajSadel
Copy link
Contributor

Works fine on my machine as well!

@JurajSadel JurajSadel self-requested a review August 31, 2022 14:26
@JurajSadel JurajSadel merged commit e9f22ac into esp-rs:main Aug 31, 2022
@jessebraham
Copy link
Member

I was waiting to merge this as I was digging into the issue. I think I actually found the change in paste the caused the issue, just need to verify and I will open an issue upstream. Guess we'll just update this dependency twice though haha.

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Aug 31, 2022

I was waiting to merge this as I was digging into the issue. I think I actually found the change in paste the caused the issue, just need to verify and I will open an issue upstream. Guess we'll just update this dependency twice though haha.

Yeah, but currently, it's broken for everyone who dares to run cargo update .... 😄 .... that's actually the case for everyone using the published HALs - for that we'd need to release esp-hal-common with the pinned version which we might not want to do unless we know a fix in paste will take longer

Also with the pinned version there is no need to rush for updating it again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants