-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix new clippy lints introduced in 1.78 & 1.79 #1776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
HIL builds for S2 and S3 are failing due to changes in the Xtensa Rust toolchain (older versions do not fail) and seems to be something in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking care of this that fast!
Hmm, I can't repro locally 🤔 |
I'm able to reproduce the errors locally, seem to originate from the [patch.crates-io]
semihosting = { git = "https://github.com/taiki-e/semihosting", tag = "v0.1.10" } ... and then running |
FYI I've opened an issue upstream for this: taiki-e/semihosting#11 |
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra: