Lift static requirement on DMA buffers
#1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
reviewed
Jul 19, 2024
Dominaezzz
reviewed
Jul 19, 2024
MabezDev
requested changes
Jul 19, 2024
bjoernQ
force-pushed
the
allow-non-static-dma-buffers
branch
from
87d794f to
935878b
Compare
jessebraham
approved these changes
Jul 25, 2024
| @@ -28,7 +28,6 @@ embassy-sync = { version = "0.6.0", optional = true } | |||
| embassy-usb-driver = { version = "0.1.0", optional = true } | |||
| embassy-usb-synopsys-otg = { version = "0.1.0", optional = true } | |||
| embedded-can = { version = "0.4.1", optional = true } | |||
| embedded-dma = "0.2.0" | |||
There was a problem hiding this comment.
Glad to see this go, never really understood the point of it honestly 😁
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
|
Looks like this needs a rebase, please! |
bjoernQ
force-pushed
the
allow-non-static-dma-buffers
branch
from
935878b to
fe7d5dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
This makes it possible to use non-static buffers for DMA. Closes #1245
Testing
All tests and examples work like before. Try using non-static DMA buffers