-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SPI DMA write/read for ESP32, ESP32-S2 #2131
Conversation
Yes, this fixes at least my issue on regular ESP32 and I can now send and receive full LoRa P2P packets.. |
Is there a chance the new test can be merged into one of the existing ones? |
Unfortunately, we need a different |
let io = Io::new(peripherals.GPIO, peripherals.IO_MUX); | ||
let sclk = io.pins.gpio0; | ||
let (miso, gpio) = hil_test::common_test_pins!(io); | ||
let _gpio = Output::new(gpio.degrade(), Level::High); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let _gpio = Output::new(gpio.degrade(), Level::High); | |
let _gpio = Output::new(gpio, Level::High); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
On ESP32 and ESP32-S2 something like this didn't work
As already found in #2059 ESP32 needs some special handling to make it work.
For ESP32-S2 the solution was found by "trial and error" (also the problem there was a bit different: on S2 the first iteration worked but then it stopped working)
Testing
I added tests and you can modify
embassy_spi.rs
example to performwrite
andread
in the loop like above