Fix interrupt executors waking up thread-mode executors on the first core #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
esp32-core1-spi
branch
2 times, most recently
from
70f14bb
to
4c49fd6
Compare
|
No change for #2369 If it was working it would not print the last line (it expects the task to update a counter every time it loops) - it never completes the first loop. |
|
Thanks! This fix is still somethat that we need to do, but at least I can investigate further. |
bugadani
force-pushed
the
esp32-core1-spi
branch
from
820aa2a
to
625fc9c
Compare
bugadani
force-pushed
the
esp32-core1-spi
branch
from
625fc9c
to
65ef161
Compare
bugadani
force-pushed
the
esp32-core1-spi
branch
from
65ef161
to
b0914bf
Compare
MabezDev
approved these changes
Oct 22, 2024
|
This does indeed fix #2369 ! |
jessebraham
approved these changes
Oct 22, 2024
elenaf9
pushed a commit
to elenaf9/esp-hal
that referenced
this pull request
Oct 24, 2024
…core (esp-rs#2377) * Clean up * Add failing multi-core test * Reset interrupts before main * Changelog * Add test case
kaspar030
pushed a commit
to kaspar030/esp-hal
that referenced
this pull request
Oct 24, 2024
…core (esp-rs#2377) * Clean up * Add failing multi-core test * Reset interrupts before main * Changelog * Add test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a clean-up commit in this PR so I recommend reviewing commit-by-commit. The actual fix is 5f2d16e
Closes #2369
Closes #2386