Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move interrupt related bits out of lib.rs and into the interrupt module #2613

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

MabezDev
Copy link
Member

@MabezDev MabezDev commented Nov 26, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Copy link
Collaborator

@Dominaezzz Dominaezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -40,6 +40,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

- Xtensa devices now correctly enable the `esp-hal-procmacros/rtc-slow` feature (#2594)
- Removed interrupt related items from lib.rs, moved to the `interrupt` module (#2613)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Removed interrupt related items from lib.rs, moved to the `interrupt` module (#2613)
- Moved interrupt related items from lib.rs to the `interrupt` module (#2613)

@bjoernQ
Copy link
Contributor

bjoernQ commented Nov 26, 2024

Besides the CI run this looks good to me - one thing I just discovered: Shouldn't we have an inherent set_interrupt_handler on the driver and let the trait impl just call that? (Probably should be done in its own PR - just noticed it here)

@bugadani
Copy link
Contributor

Besides the CI run this looks good to me - one thing I just discovered: Shouldn't we have an inherent set_interrupt_handler on the driver and let the trait impl just call that? (Probably should be done in its own PR - just noticed it here)

Frankly speaking I don't see too much value in the trait at all.

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would also probably like to see InterruptConfigurable go away unless there is some reason to keep it, but given that it already existed can be done here or in another PR, doesn't matter to me.

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - instead of removing InterruptConfigurable we can also just make sure we have an inherent set_interrupt_handler function everywhere - but not in the scope of this PR

@bjoernQ bjoernQ added this pull request to the merge queue Nov 27, 2024
Merged via the queue into esp-rs:main with commit 7095576 Nov 27, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants