Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blinky_erased_pins example for ESP32-H2 #530

Merged
merged 5 commits into from
May 12, 2023

Conversation

SergioGasquez
Copy link
Member

  • Add blinky_erased_pins example for ESP32-H2
  • Update docstrings of the example

Don't have LEDs to test it but checked it with the LA:
image

@SergioGasquez SergioGasquez requested a review from jessebraham May 11, 2023 10:58
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Also checked on HW. Nice you added some comments to the examples

@SergioGasquez SergioGasquez merged commit fa3627c into esp-rs:main May 12, 2023
@SergioGasquez SergioGasquez deleted the feature/esp32h2-blinky branch May 12, 2023 12:18
SergioGasquez added a commit to SergioGasquez/esp-hal that referenced this pull request Jun 9, 2023
* feat: ✨ Add blinky_erased_pins example

* docs: 📝 Update docstrings

* docs: 📝 Update changelog
i404788 pushed a commit to i404788/esp-hal that referenced this pull request Jul 22, 2023
* feat: ✨ Add blinky_erased_pins example

* docs: 📝 Update docstrings

* docs: 📝 Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants