async gpio fixes #537
Merged
async gpio fixes #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No more misfires, thanks! |
|
One thing, though, regarding the implementation: what do you think about clearing status after the loop, instead of every iteration? It's unlikely that multiple GPIOs interrupt at the same time, but it's still probably enough to clear the status registers once at the end - we have the bit patterns to do this. |
MabezDev
force-pushed
the
async/gpio-fixups
branch
2 times, most recently
from
28ac7a4
to
39c373b
Compare
MabezDev
force-pushed
the
async/gpio-fixups
branch
from
39c373b
to
68f3923
Compare
|
Don't merge yet, sorry I've realised this might not be correct. |
- Fix pin number calculation for bank1 - Clear interrupt status after disabling interrupt to avoid hardware pending another interrupt - Clear interrupt status per pin when we create the input future
MabezDev
force-pushed
the
async/gpio-fixups
branch
from
68f3923
to
6853aac
Compare
|
I had a last-second wobble as @bugadani pointed out a possible logical error. However, in practice the hardware (at least on C3/S3) will clear the gpio interrupt status bit when |
SergioGasquez
pushed a commit
to SergioGasquez/esp-hal
that referenced
this pull request
Jun 9, 2023
* async gpio fixes - Fix pin number calculation for bank1 - Clear interrupt status after disabling interrupt to avoid hardware pending another interrupt - Clear interrupt status per pin when we create the input future * add changelog item
i404788
pushed a commit
to i404788/esp-hal
that referenced
this pull request
Jul 22, 2023
* async gpio fixes - Fix pin number calculation for bank1 - Clear interrupt status after disabling interrupt to avoid hardware pending another interrupt - Clear interrupt status per pin when we create the input future * add changelog item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InputFuturecreation.Close #535