Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix half-duplex SPI read #552

Merged
merged 2 commits into from
May 22, 2023

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented May 19, 2023

When testing with a QSPI RAM chip it turned out that the non-DMA reading sometimes reads garbage in non-release mode.

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bjoernQ bjoernQ force-pushed the bugfix/fix-halfduplex-read-in-debug-mode branch from 0458f2b to aa96c71 Compare May 22, 2023 11:46
@bjoernQ bjoernQ merged commit 7b3e19c into esp-rs:main May 22, 2023
@bjoernQ bjoernQ deleted the bugfix/fix-halfduplex-read-in-debug-mode branch May 22, 2023 12:02
SergioGasquez pushed a commit to SergioGasquez/esp-hal that referenced this pull request Jun 9, 2023
* Fix half-duplex SPI read

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants