-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix insertion location of trap section in ram #605
Conversation
This will fix the problem of esp-wifi not working anymore with the latest HAL 🎉 The reason might be:
Here Placing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need this fix also for db-riscv-link.x
and mb-riscv-link.x
files
4bfb5fe
to
52683bb
Compare
Nice find, that makes total sense! I've added the changes to the DB and MCUboot scripts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this
* Fix insertion location of trap section in ram * Apply fixes for db and mcuboot * Add changelog
* Fix insertion location of trap section in ram * Apply fixes for db and mcuboot * Add changelog
Although it shouldn't matter where the trap section is located in IRAM, it seems it does. Placing it before other IRAM items seems to resolve #604.
Must
errors
orwarnings
.cargo fmt
was run.CHANGELOG.md
in the proper section.Nice to have
Closes #604