rmt: Add support for transmitting rust iterators #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `rmt::Transmit::start_iter` and `rmt::Transmit::start_iter_blocking` that allow to transmit items generated on-the-fly by a rust iterator. This is done by using the `translator` feature of the rmt peripheral.
MabezDev
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
This is really cool! I didn't know the hardware could do this! We might need to revisit rmt in general when v5.0 is released, a lot of breaking changes... https://docs.espressif.com/projects/esp-idf/en/latest/esp32/migration-guides/release-5.x/peripherals.html#rmt-driver.
but until then, LGTM!
dsheets
added a commit
to dsheets/esp-idf-hal
that referenced
this pull request
Dec 21, 2023
This makes it much easier to use `TxRmtDriver::start_iter` and `TxRmtDriver::start_iter_blocking` (esp-rs#113).
dsheets
added a commit
to dsheets/esp-idf-hal
that referenced
this pull request
Jan 27, 2024
This makes it much easier to use `TxRmtDriver::start_iter` and `TxRmtDriver::start_iter_blocking` (esp-rs#113).
ivmarkov
pushed a commit
that referenced
this pull request
Jan 31, 2024
* rmt: wrap rmt_item32_t in a newtype This makes it much easier to use `TxRmtDriver::start_iter` and `TxRmtDriver::start_iter_blocking` (#113). * examples/rmt_musical_buzzer: fix for ESP32 Possibly broken by #97, possibly never worked. The ESP-IDF repo specifically excludes the ESP32 from the RMT musical buzzer demo because its RMT unit lacks hardware looping. Before this change, the demo would simply hang when trying to play the second note possibly because the ESP32 RMT unit does not support asynchronous stopping. As an added bonus, this example is now much easier to modify to experiment with 1-bit chiptune synthesis by making every symbol (cycle) accessible in the ISR iterator. * rmt: remove Pulse::into_rmt_item in favor of Symbol::new Also, factor Pulse pairs into function arguments for ease of use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
rmt::Transmit::start_iterandrmt::Transmit::start_iter_blockingthat allow totransmit items generated on-the-fly by a rust iterator. This is done by using the
translatorfeature of the rmt peripheral.See the documentation in the code for how it works exactly.