Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for TLS server #368

Merged
merged 10 commits into from
Mar 6, 2024
Merged

Support for TLS server #368

merged 10 commits into from
Mar 6, 2024

Conversation

torkleyy
Copy link
Contributor

@ivmarkov Do you think something along those lines will work so we can also support accepted server clients?

@ivmarkov
Copy link
Collaborator

@torkleyy I haven't tried that yet, and cannot assess 100% whether your approach would work, but yes - I would start the same way as you did.

Would you like to bring this to completion?

@torkleyy
Copy link
Contributor Author

Yes, I will finish it this week. Thanks for your feedback @ivmarkov

@torkleyy torkleyy marked this pull request as ready for review February 23, 2024 16:59
src/tls.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@ivmarkov ivmarkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my other comment - lets remove the async negotiate_server variant, until we have a fix / workaround.

@ivmarkov ivmarkov merged commit bbd7133 into esp-rs:master Mar 6, 2024
12 checks passed
@torkleyy torkleyy deleted the tls-server branch March 6, 2024 06:39
owenthewizard pushed a commit to owenthewizard/esp-idf-svc that referenced this pull request Apr 11, 2024
* Sketch for tls server

* Implement ServerConfig

* Fix errors

* Add missing cfg

* Also add for async version

* Make clippy happy

* Add missing cfgs

* Allow retrieving raw context handle

* Use esp_tls_conn_destroy unconditionally

* Comment out async negotiate_server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants