Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP-IDF 5 introduced a new timer api and made the old one "deprecated". This change make it available for consumers of esp-idf-sys.
This variant to just expose it for all versions greater > 4 is the simplest of all but comes with the following potential problems:
Unfortunately esp-idf doesn't expose a good kconfig variable, to selectively import the headers based on it. If we are desperate we could hack into the "GPTIMER_SUPPRESS_DEPRECATE_WARN" kconfig, if the user set this in his sdkconfig file we would only compile the new one and if its unset it would use the old api. Since this is really hacky i suppose we should just go with the first option for now.
My driver downstream in (esp-idf-hal) will be feature gated for now, and if activated, will disable the old driver completely. Though it would be nicer if we could get that info from upstream.