Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ update bindgen to latest version #304

Merged
merged 3 commits into from
May 27, 2024

Conversation

Vollbrecht
Copy link
Collaborator

@Vollbrecht Vollbrecht commented May 21, 2024

The changelog of bindgen added a lot between 0.63 and 0.69 though it still seams to work without any problems. They introduces some new features that may be interesting in the future - like creating bindgens for C functions that are inlined in the api and thus currently not producing any bindgen output etc.

This change is also needed when esp-rs/embuild#85 lands so we have version parity between both

@ivmarkov
Copy link
Collaborator

I assume we can only do this once we update the bindgen util in embuild itself?

@Vollbrecht
Copy link
Collaborator Author

I assume we can only do this once we update the bindgen util in embuild itself?

We already bumped the bindgen version in embuild on master some time ago, but yes both versions need to be the same to work. Though no additional specif work is needed as far as i can see. Only if we want to use some of the newer features that were introduced.

@Vollbrecht
Copy link
Collaborator Author

as discussed in matrix we will point esp-idf-sys master to embuild git master, so we can test if it works on any platform.

@Vollbrecht Vollbrecht merged commit b9fa477 into esp-rs:master May 27, 2024
12 checks passed
@ivmarkov
Copy link
Collaborator

The problem is, now you need to multiply this [patch.crates-io] section in all crates. Well, if we had workspace build, then... you know what I'll say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants