Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to v4.4 #9

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Default to v4.4 #9

merged 1 commit into from
Mar 31, 2022

Conversation

MabezDev
Copy link
Member

v4.4 is now officially released. v4.4 has most (all?) the patches we need from the Rust side, including realpath so we can now remove panic_immediate_abort feature.

@ivmarkov
Copy link
Collaborator

Shall we wait on that a bit until PlatformIO picks up 4.4 as well?

The good news is that this seemingly got merged in 4.4 as well, which means that native bulid on Windows should no longer have the "too long linker commandline" problem. Let me try that...

@MabezDev
Copy link
Member Author

Shall we wait on that a bit until PlatformIO picks up 4.4 as well?

Good idea! Better to be in-sync across all our approaches.

@MabezDev MabezDev mentioned this pull request Jan 27, 2022
Closed
@ivmarkov
Copy link
Collaborator

The good news is that this seemingly got merged in 4.4 as well, which means that native bulid on Windows should no longer have the "too long linker commandline" problem. Let me try that...

Yes! Confirmed! Native build finally works on Windows! Such nice...

@MabezDev MabezDev force-pushed the feature/default-v4.4 branch 2 times, most recently from be14b14 to d954428 Compare March 30, 2022 12:48
@MabezDev
Copy link
Member Author

Updated this to support the recent change to native build by default. CI is failing because rustfmt is broken in nightly.

@ivmarkov ivmarkov merged commit d92ab84 into master Mar 31, 2022
@ivmarkov ivmarkov deleted the feature/default-v4.4 branch October 17, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivmarkov ivmarkov Awaiting requested review from ivmarkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MabezDev @ivmarkov