Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to esp-hal 0.18.0 #30

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Update to esp-hal 0.18.0 #30

merged 2 commits into from
Jul 15, 2024

Conversation

AnthonyGrondin
Copy link
Contributor

⚠️ Breaking Change ⚠️

  • The rsa field of Session::new() now take the peripheral directly, instead of an instance of the driver, so that we can instantiate the driver ourselves, in blocking mode. This now also allow creating a session in a trait impl that immutably borrow &self without triggering the borrow checker, by declaring a field with RefCell<Option<esp_hal::peripherals::RSA>>, and calling Session::new() with the following for the rsa field:
if let Ok(ref mut rsa) = self.rsa.try_borrow_mut() {
    rsa.as_mut()
} else {
    None
},

This revert the change made in esp-rs#27 now that Session no longer take an instance of the driver.
Copy link
Collaborator

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me

@bjoernQ bjoernQ merged commit c619fad into esp-rs:main Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants