feat: place __INTERRUPTS vector in .trap.rodata #119
Conversation
This commit preemptively adopts the change proposed to [svd2rust] to expose the link section as a config parameter. [svd2rust]: rust-embedded/svd2rust#718
via: ``` (cd xtask; cargo run -- --generate-only) ```
Rust-analyzer's "all targets" default mode runs afoul of `#[no_std]` crates that don't have a test harness. This change tells cargo (and indirectly, rust-analyzer) that we have no expectation for that to work. The CI changes don't have any effect currently, since none of these crates have any `bin`s or `example`s, but it does check that the rust-analzyzer complaints won't crop back up in the future.
There was a problem hiding this comment.
This looks good from my perspective, I don't really see an issue depending on a git version of svd2rust.
I'll defer to @jessebraham regarding the rust-analyzer commit.
|
Cool, it looks like rust-embedded/svd2rust#718 got merged with no changes, so I'll just re-point this to the "official" sha and then I'm happy with this one. |
| @@ -42,7 +42,7 @@ jobs: | |||
| - name: generate pac | |||
| run: cargo run --manifest-path=xtask/Cargo.toml -- --generate-only ${{ matrix.chip }} | |||
| - name: build pac | |||
| run: cd ${{ matrix.chip }} && cargo check | |||
| run: cd ${{ matrix.chip }} && cargo check --all-targets | |||
There was a problem hiding this comment.
Why is this option required? Just curious
There was a problem hiding this comment.
It's a good question! I'm fairly sure it doesn't do anything for these crates in the present: the idea is to line CI up with the default developer experience so someone like me who's just running git clone && code hopefully gets a project with no spurious rust-analyzer errors.
That's only as important as preserving that property, which it seems like we're at least loosely agreed about being worthwhile. It's also only as effective as the purpose of that --all-targets is clear, which is why I'm glad you asked!
This change preemptively adopts the change proposed to svd2rust to
expose the link section as a config parameter.
I split out the changes to the generator from the actual update of the generated files to make it a little easier to review, since the generated code changes are a little noisy.
It also addresses an unrelated issue I ran into with rust-analyzer (by way of vscode) in 64e16da . Just let me know if you hate it, and I'll pop it off this PR.