This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Add esp-wifi support #113
Merged
Add esp-wifi support #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
reviewed
Sep 19, 2023
Yikes 😅. Maybe we need to split these into separate templates? Not sure the best way to do this to be honest 🤔. |
Yep, wanted to start a discussion about this in #110. My initial idea was to have 2 folders in |
SergioGasquez
force-pushed
the
feature/esp-wifi
branch
from
bf4f276 to
7ea98fa
Compare
MabezDev
approved these changes
Sep 20, 2023
Co-authored-by: Scott Mabin <scott@mabez.dev>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial esp-wifi support, when enabled it adds the code to connect to a Wifi network
Downsides:
ifsrustfmtdoes not complain but still weird)