-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async WiFi #125
Async WiFi #125
Conversation
- Add embassy_net::Driver impl for WifiDevice - Add embassy_dhcp example - Update README with embassy_dhcp running instruction Notes: TCP connection may fail a few times until the esp gets an IP address, it seems there is no way to await dhcp completion in embassy_net yet.
- Whilst other embassy crates can be used behind the async feature, embassy-net should be put behind its own feature
Awesome! ❤️ I also don't see any problems from using embedded-io 0.4.0 in but there is a crash now with the ESP32-S3 BLE example
|
Looks like we're running into the loop optimization issue again, |
Ah yes - I once again forgot about that - I agree and it shouldn't hold us back from getting this in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Async WiFi with embassy - Add embassy_net::Driver impl for WifiDevice - Add embassy_dhcp example - Update README with embassy_dhcp running instruction Notes: TCP connection may fail a few times until the esp gets an IP address, it seems there is no way to await dhcp completion in embassy_net yet. * Put embassy-net behind feature - Whilst other embassy crates can be used behind the async feature, embassy-net should be put behind its own feature * wait for dhcp to complete in example * fmt * Simplify embedded-io import * Update README, use new bleps
This PR adds embassy_net support to esp-wifi, along with a embassy based DHCP example. Currently connecting to WiFi is blocking, and is completed before starting the executor. This is mainly due to the
embedded_svc
traits for wifi being blocking at the moment, but we could easily add our own async interface toWiFiDevice
in another PR.TODO