Add minimal amount of default features #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
reviewed
Jan 23, 2024
MabezDev
force-pushed
the
min-default-features
branch
from
4caecbe to
53ba13b
Compare
bjoernQ
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
I guess this doesn't need a CHANGELOG.md entry so no need to wait for the other PR
But probably the new feature should be listed in https://github.com/esp-rs/esp-wifi/tree/main/esp-wifi#features
…usly default features only for examples
MabezDev
force-pushed
the
min-default-features
branch
from
53ba13b to
b9e4c59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the discussion in esp-rs/esp-template#141