Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement #430

Merged
merged 5 commits into from
Feb 8, 2024
Merged

Performance improvement #430

merged 5 commits into from
Feb 8, 2024

Commits on Feb 5, 2024

  1. Improve response times

    When the network interface can't make any progress, it's probably
    a good idea to yeild the task so that the wifi task may run and
    proceed with actually sending/receiving data.
    
    This seems to greatly improve response times, especially with low
    tick_rate_hz values. At 100Hz, ping time goes down from 25ms to
    <2ms. A simple http server test saw a response time reduction from
    45ms to 6ms. At 1000Hz tick rate the gains are diminishing but
    there are some small gains. I ran my tests on esp32s3.
    
    This might also increase throughput. I have not tested that.
    It also may have some unforseen adverse effects.
    
    Ideally, we would have a more fine grained return value from
    interface.poll() than a bool so we have a better idea if yeilding
    is appropriate or not.
    karlri authored and bjoernQ committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    77c437a View commit details
    Browse the repository at this point in the history
  2. Revert "Improve response times"

    This reverts commit 77c437a.
    bjoernQ committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    e00d318 View commit details
    Browse the repository at this point in the history
  3. Fix embassy_bench

    bjoernQ committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    1084673 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    db1065b View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. CHANGELOG.md entry

    bjoernQ committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    8fc04ad View commit details
    Browse the repository at this point in the history