Allow skipping the padding for image files #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebraham
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
This seems reasonable enough, thank you for contributing!
Before I merge, I just wanted to note that we are in the process of re-licensing the project (see #224 for details), so if you could please comment in that issue or in this PR stating that you consent to the new licensing (assuming you do, of course!) then I will happily merge this.
|
Sure thing! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
espflashcreates a 16MB image when specifying a flash size of 16MB. When mass producing devices a flash size of 16MB significantly slows down the flashing process without any benefit.In order to not break backwards compatibility and expectations a new command line switch has been introduced
--skip-padding, which reduces the image size to only what is really used.