Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address minor feedback things of rc.1 #589

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Feb 19, 2024

  • Prepare CHANGELOG for next dev-cycle
  • Update log message when we skip writing a segment. Here is how it looks, reflashing an app where only the app changed:
    ...
    App/part. size:    223,776/4,128,768 bytes, 5.42%
    [2024-02-19T09:16:12Z INFO ] Segment at address '0x0' did not change, skipping it
    [2024-02-19T09:16:12Z INFO ] Segment at address '0x8000' did not change, skipping it
    [00:00:01] [========================================]      74/74      0x10000                                                                                                                                                                                    [2024-02-19T09:16:14Z INFO ] Flashing has completed!
    
  • Include the removal of Cargo package metadata configuration in changelog.

cc: @jessebraham @Vollbrecht

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes it a bit more clear to users what's going on now. Thanks!

@MabezDev MabezDev merged commit 50b42d5 into esp-rs:main Feb 19, 2024
20 checks passed
@SergioGasquez SergioGasquez deleted the feat/rc-feedback branch February 19, 2024 11:56
@Vollbrecht
Copy link

Thanks, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants