Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some errors for GitHub API #464

Merged
merged 6 commits into from
Dec 13, 2024
Merged

Add some errors for GitHub API #464

merged 6 commits into from
Dec 13, 2024

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Dec 13, 2024 •
edited
Loading

Supersedes #394

cc: @leongross

@SergioGasquez SergioGasquez mentioned this pull request Dec 13, 2024
Closed
@SergioGasquez SergioGasquez changed the title Add some errors for GItHub API Add some errors for GitHub API Dec 13, 2024
leongross
leongross approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@leongross leongross left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up; lgtm!

@SergioGasquez SergioGasquez merged commit ec99641 into esp-rs:main Dec 13, 2024
17 checks passed
@SergioGasquez SergioGasquez deleted the fix/gh-token branch December 13, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leongross leongross leongross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergioGasquez @leongross